Skip to content

Commit

Permalink
tracing: fix section mismatch in trace_hw_branches.c
Browse files Browse the repository at this point in the history
The function bts_trace_init() references a variable
bts_hotcpu_notifier which is marked
as __cpuinitdata. Thus causes section mismatch. This patch fixes it.

   LD      kernel/trace/built-in.o
 WARNING: kernel/trace/built-in.o(.text+0xc90c): Section mismatch in
 reference from the function bts_trace_init() to the variable
 .cpuinit.data:bts_hotcpu_notifier
 The function bts_trace_init() references
 the variable __cpuinitdata bts_hotcpu_notifier.
 This is often because bts_trace_init lacks a __cpuinitdata
 annotation or the annotation of bts_hotcpu_notifier is wrong.

 WARNING: kernel/trace/built-in.o(.text+0xc92a): Section mismatch in
 reference from the function bts_trace_reset() to the variable
 .cpuinit.data:bts_hotcpu_notifier
 The function bts_trace_reset() references
 the variable __cpuinitdata bts_hotcpu_notifier.
 This is often because bts_trace_reset lacks a __cpuinitdata
 annotation or the annotation of bts_hotcpu_notifier is wrong.

Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
Cc: markus.t.metzger@gmail.com
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Rakib Mullick authored and Ingo Molnar committed Feb 15, 2009
1 parent 9abd603 commit a234aa9
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions kernel/trace/trace_hw_branches.c
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ static struct notifier_block bts_hotcpu_notifier __cpuinitdata = {
.notifier_call = bts_hotcpu_handler
};

static int bts_trace_init(struct trace_array *tr)
static int __cpuinit bts_trace_init(struct trace_array *tr)
{
hw_branch_trace = tr;

Expand All @@ -137,7 +137,7 @@ static int bts_trace_init(struct trace_array *tr)
return 0;
}

static void bts_trace_reset(struct trace_array *tr)
static void __cpuinit bts_trace_reset(struct trace_array *tr)
{
bts_trace_stop(tr);
unregister_hotcpu_notifier(&bts_hotcpu_notifier);
Expand Down

0 comments on commit a234aa9

Please sign in to comment.