Skip to content

Commit

Permalink
Revert "tcp: Always set urgent pointer if it's beyond snd_nxt"
Browse files Browse the repository at this point in the history
This reverts commit 64ff3b9.

Jeff Chua reports that it breaks rlogin for him.

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David S. Miller committed Feb 5, 2009
1 parent 0178b69 commit a23f4bb
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions net/ipv4/tcp_output.c
Original file line number Diff line number Diff line change
Expand Up @@ -663,14 +663,10 @@ static int tcp_transmit_skb(struct sock *sk, struct sk_buff *skb, int clone_it,
th->urg_ptr = 0;

/* The urg_mode check is necessary during a below snd_una win probe */
if (unlikely(tcp_urg_mode(tp))) {
if (between(tp->snd_up, tcb->seq + 1, tcb->seq + 0xFFFF)) {
th->urg_ptr = htons(tp->snd_up - tcb->seq);
th->urg = 1;
} else if (after(tcb->seq + 0xFFFF, tp->snd_nxt)) {
th->urg_ptr = 0xFFFF;
th->urg = 1;
}
if (unlikely(tcp_urg_mode(tp) &&
between(tp->snd_up, tcb->seq + 1, tcb->seq + 0xFFFF))) {
th->urg_ptr = htons(tp->snd_up - tcb->seq);
th->urg = 1;
}

tcp_options_write((__be32 *)(th + 1), tp, &opts, &md5_hash_location);
Expand Down

0 comments on commit a23f4bb

Please sign in to comment.