Skip to content

Commit

Permalink
slub: Dont define useless label in the !CONFIG_CMPXCHG_LOCAL case
Browse files Browse the repository at this point in the history
The redo label needs #ifdeffery. Fixes the following problem introduced by
commit 8a5ec0b ("Lockless (and preemptless) fastpaths for slub"):

  mm/slub.c: In function 'slab_free':
  mm/slub.c:2124: warning: label 'redo' defined but not used

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Christoph Lameter <cl@linux.com>
Signed-off-by: Pekka Enberg <penberg@kernel.org>
  • Loading branch information
Christoph Lameter authored and Pekka Enberg committed Mar 20, 2011
1 parent 8a5ec0b commit a24c5a0
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion mm/slub.c
Original file line number Diff line number Diff line change
Expand Up @@ -2073,9 +2073,11 @@ static __always_inline void slab_free(struct kmem_cache *s,

#ifndef CONFIG_CMPXCHG_LOCAL
local_irq_save(flags);
#endif

#else
redo:
#endif

/*
* Determine the currently cpus per cpu slab.
* The cpu may change afterward. However that does not matter since
Expand Down

0 comments on commit a24c5a0

Please sign in to comment.