Skip to content

Commit

Permalink
selftests: bonding: do not test arp/ns target with mode balance-alb/tlb
Browse files Browse the repository at this point in the history
The prio_arp/ns tests hard code the mode to active-backup. At the same
time, The balance-alb/tlb modes do not support arp/ns target. So remove
the prio_arp/ns tests from the loop and only test active-backup mode.

Fixes: 481b56e ("selftests: bonding: re-format bond option tests")
Reported-by: Jay Vosburgh <jay.vosburgh@canonical.com>
Closes: https://lore.kernel.org/netdev/17415.1705965957@famine/
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com>
Link: https://lore.kernel.org/r/20240123075917.1576360-1-liuhangbin@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
  • Loading branch information
Hangbin Liu authored and Paolo Abeni committed Jan 25, 2024
1 parent a717932 commit a2933a8
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions tools/testing/selftests/drivers/net/bonding/bond_options.sh
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ prio_arp()
local mode=$1

for primary_reselect in 0 1 2; do
prio_test "mode active-backup arp_interval 100 arp_ip_target ${g_ip4} primary eth1 primary_reselect $primary_reselect"
prio_test "mode $mode arp_interval 100 arp_ip_target ${g_ip4} primary eth1 primary_reselect $primary_reselect"
log_test "prio" "$mode arp_ip_target primary_reselect $primary_reselect"
done
}
Expand All @@ -178,7 +178,7 @@ prio_ns()
fi

for primary_reselect in 0 1 2; do
prio_test "mode active-backup arp_interval 100 ns_ip6_target ${g_ip6} primary eth1 primary_reselect $primary_reselect"
prio_test "mode $mode arp_interval 100 ns_ip6_target ${g_ip6} primary eth1 primary_reselect $primary_reselect"
log_test "prio" "$mode ns_ip6_target primary_reselect $primary_reselect"
done
}
Expand All @@ -194,9 +194,9 @@ prio()

for mode in $modes; do
prio_miimon $mode
prio_arp $mode
prio_ns $mode
done
prio_arp "active-backup"
prio_ns "active-backup"
}

arp_validate_test()
Expand Down

0 comments on commit a2933a8

Please sign in to comment.