Skip to content

Commit

Permalink
selftests/mm: speed up split_huge_page_test
Browse files Browse the repository at this point in the history
create_pagecache_thp_and_fd() was previously writing a file sized at twice
the PMD size by making a per-byte write syscall.  This was quite slow when
the PMD size is 4M, but completely intolerable for 32M (PMD size for
arm64's 16K page size), and 512M (PMD size for arm64's 64K page size).

The byte pattern has a 256 byte period, so let's create a 1K buffer and
fill it with exactly 4 periods.  Then we can write the buffer as many
times as is required to fill the file.  This makes things much more
tolerable.

The test now passes for 16K page size.  It still fails for 64K page size
because MAX_PAGECACHE_ORDER is too small for 512M folio size (I think).

Link: https://lkml.kernel.org/r/20250318174343.243631-3-ryan.roberts@arm.com
Signed-off-by: Ryan Roberts <ryan.roberts@arm.com>
Acked-by: Peter Xu <peterx@redhat.com>
Acked-by: Rafael Aquini <raquini@redhat.com>
Cc: Shuah Khan <shuah@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
  • Loading branch information
Ryan Roberts authored and Andrew Morton committed Mar 22, 2025
1 parent 735b3f7 commit a2c6f9c
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions tools/testing/selftests/mm/split_huge_page_test.c
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
*/

#define _GNU_SOURCE
#include <assert.h>
#include <stdio.h>
#include <stdlib.h>
#include <stdarg.h>
Expand Down Expand Up @@ -398,18 +399,20 @@ int create_pagecache_thp_and_fd(const char *testfile, size_t fd_size, int *fd,
{
size_t i;
int dummy = 0;
unsigned char buf[1024];

srand(time(NULL));

*fd = open(testfile, O_CREAT | O_RDWR, 0664);
if (*fd == -1)
ksft_exit_fail_msg("Failed to create a file at %s\n", testfile);

for (i = 0; i < fd_size; i++) {
unsigned char byte = (unsigned char)i;
assert(fd_size % sizeof(buf) == 0);
for (i = 0; i < sizeof(buf); i++)
buf[i] = (unsigned char)i;
for (i = 0; i < fd_size; i += sizeof(buf))
write(*fd, buf, sizeof(buf));

write(*fd, &byte, sizeof(byte));
}
close(*fd);
sync();
*fd = open("/proc/sys/vm/drop_caches", O_WRONLY);
Expand Down

0 comments on commit a2c6f9c

Please sign in to comment.