Skip to content

Commit

Permalink
ACPI: video: Drop backlight_device_get_by_type() call from acpi_video…
Browse files Browse the repository at this point in the history
…_get_backlight_type()

All x86/ACPI kms drivers which register native/BACKLIGHT_RAW type
backlight devices call acpi_video_backlight_use_native() now. This sets
__acpi_video_get_backlight_type()'s internal static native_available flag.

This makes the backlight_device_get_by_type(BACKLIGHT_RAW) check
unnecessary.

Relying on the cached native_available value not only is simpler, it will
also work correctly in cases where then native backlight registration was
skipped because of acpi_video_backlight_use_native() returning false.

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
  • Loading branch information
Hans de Goede committed Sep 2, 2022
1 parent 7f908d3 commit a2fc3c8
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/acpi/video_detect.c
Original file line number Diff line number Diff line change
Expand Up @@ -608,8 +608,7 @@ static enum acpi_backlight_type __acpi_video_get_backlight_type(bool native)
if (!(video_caps & ACPI_VIDEO_BACKLIGHT))
return acpi_backlight_vendor;

if (acpi_osi_is_win8() &&
(native_available || backlight_device_get_by_type(BACKLIGHT_RAW)))
if (acpi_osi_is_win8() && native_available)
return acpi_backlight_native;

return acpi_backlight_video;
Expand Down

0 comments on commit a2fc3c8

Please sign in to comment.