Skip to content

Commit

Permalink
viafb: correct sync polarity for OLPC DCON
Browse files Browse the repository at this point in the history
While the OLPC display appears to be able to handle either positive
or negative sync, the Display Controller only recognises positive sync.

This brings viafb (for XO-1.5) in line with lxfb (for XO-1) and
fixes a recent regression where the XO-1.5 DCON could no longer be
frozen. Thanks to Florian Tobias Schandinat for helping identify
the fix.

Test case: from a vt,
	echo 1 > /sys/devices/platform/dcon/freeze
should cause the current screen contents to freeze, rather than garbage being
displayed.

Signed-off-by: Daniel Drake <dsd@laptop.org>
Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Cc: stable@kernel.org
  • Loading branch information
Daniel Drake authored and Florian Tobias Schandinat committed Nov 22, 2011
1 parent 5008484 commit a328396
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/video/via/share.h
Original file line number Diff line number Diff line change
Expand Up @@ -559,8 +559,8 @@
#define M1200X720_R60_VSP POSITIVE

/* 1200x900@60 Sync Polarity (DCON) */
#define M1200X900_R60_HSP NEGATIVE
#define M1200X900_R60_VSP NEGATIVE
#define M1200X900_R60_HSP POSITIVE
#define M1200X900_R60_VSP POSITIVE

/* 1280x600@60 Sync Polarity (GTF Mode) */
#define M1280x600_R60_HSP NEGATIVE
Expand Down

0 comments on commit a328396

Please sign in to comment.