Skip to content

Commit

Permalink
net: remove sock_poll_busy_flag
Browse files Browse the repository at this point in the history
Fold it into the only caller to make the code simpler and easier to read.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Christoph Hellwig authored and David S. Miller committed Jul 30, 2018
1 parent f641f13 commit a331de3
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
6 changes: 0 additions & 6 deletions include/net/busy_poll.h
Original file line number Diff line number Diff line change
Expand Up @@ -121,12 +121,6 @@ static inline void sk_busy_loop(struct sock *sk, int nonblock)
#endif
}

/* if this socket can poll_ll, tell the system call */
static inline __poll_t sock_poll_busy_flag(struct socket *sock)
{
return sk_can_busy_loop(sock->sk) ? POLL_BUSY_LOOP : 0;
}

/* used in the NIC receive handler to mark the skb */
static inline void skb_mark_napi_id(struct sk_buff *skb,
struct napi_struct *napi)
Expand Down
16 changes: 11 additions & 5 deletions net/socket.c
Original file line number Diff line number Diff line change
Expand Up @@ -1130,15 +1130,21 @@ EXPORT_SYMBOL(sock_create_lite);
static __poll_t sock_poll(struct file *file, poll_table *wait)
{
struct socket *sock = file->private_data;
__poll_t events = poll_requested_events(wait);
__poll_t events = poll_requested_events(wait), flag = 0;

if (!sock->ops->poll)
return 0;

/* poll once if requested by the syscall */
if (sk_can_busy_loop(sock->sk) && (events & POLL_BUSY_LOOP))
sk_busy_loop(sock->sk, 1);
return sock->ops->poll(file, sock, wait) | sock_poll_busy_flag(sock);
if (sk_can_busy_loop(sock->sk)) {
/* poll once if requested by the syscall */
if (events & POLL_BUSY_LOOP)
sk_busy_loop(sock->sk, 1);

/* if this socket can poll_ll, tell the system call */
flag = POLL_BUSY_LOOP;
}

return sock->ops->poll(file, sock, wait) | flag;
}

static int sock_mmap(struct file *file, struct vm_area_struct *vma)
Expand Down

0 comments on commit a331de3

Please sign in to comment.