Skip to content

Commit

Permalink
drm/msm: Remove dangling submitqueue references
Browse files Browse the repository at this point in the history
Currently it doesn't matter, since we free the ctx immediately.  But
when we start refcnt'ing the ctx, we don't want old dangling list
entries to hang around.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
  • Loading branch information
Rob Clark committed Sep 12, 2020
1 parent 08d3ab4 commit a3367f5
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/gpu/drm/msm/msm_submitqueue.c
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,10 @@ void msm_submitqueue_close(struct msm_file_private *ctx)
* No lock needed in close and there won't
* be any more user ioctls coming our way
*/
list_for_each_entry_safe(entry, tmp, &ctx->submitqueues, node)
list_for_each_entry_safe(entry, tmp, &ctx->submitqueues, node) {
list_del(&entry->node);
msm_submitqueue_put(entry);
}
}

int msm_submitqueue_create(struct drm_device *drm, struct msm_file_private *ctx,
Expand Down

0 comments on commit a3367f5

Please sign in to comment.