Skip to content

Commit

Permalink
xen/xenbus: clean up noise in xenbus_probe.c
Browse files Browse the repository at this point in the history
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
[corresponds to 01aded30aaef in git://git.kernel.org/pub/scm/linux/kernel/git/jeremy/xen.git]
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
  • Loading branch information
Jeremy Fitzhardinge authored and Konrad Rzeszutek Wilk committed Jan 5, 2011
1 parent a16448e commit a39bda2
Showing 1 changed file with 6 additions and 23 deletions.
29 changes: 6 additions & 23 deletions drivers/xen/xenbus/xenbus_probe.c
Original file line number Diff line number Diff line change
Expand Up @@ -479,23 +479,16 @@ static int xenbus_probe_device_type(struct xen_bus_type *bus, const char *type)
unsigned int dir_n = 0;
int i;

printk(KERN_CRIT "%s type %s\n", __func__, type);

dir = xenbus_directory(XBT_NIL, bus->root, type, &dir_n);
if (IS_ERR(dir)) {
printk(KERN_CRIT "%s failed xenbus_directory\n", __func__);
if (IS_ERR(dir))
return PTR_ERR(dir);
}

for (i = 0; i < dir_n; i++) {
printk(KERN_CRIT "%s %d/%d %s\n", __func__, i+1,dir_n, dir[i]);
err = bus->probe(bus, type, dir[i]);
if (err) {
printk(KERN_CRIT "%s failed\n", __func__);
if (err)
break;
}
}
printk("%s done\n", __func__);

kfree(dir);
return err;
}
Expand All @@ -506,23 +499,16 @@ int xenbus_probe_devices(struct xen_bus_type *bus)
char **dir;
unsigned int i, dir_n;

printk(KERN_CRIT "%s %s\n", __func__, bus->root);

dir = xenbus_directory(XBT_NIL, bus->root, "", &dir_n);
if (IS_ERR(dir)) {
printk(KERN_CRIT "%s failed xenbus_directory\n", __func__);
if (IS_ERR(dir))
return PTR_ERR(dir);
}

for (i = 0; i < dir_n; i++) {
printk(KERN_CRIT "%s %d/%d %s\n", __func__, i+1,dir_n, dir[i]);
err = xenbus_probe_device_type(bus, dir[i]);
if (err) {
printk(KERN_CRIT "%s failed\n", __func__);
if (err)
break;
}
}
printk("%s done\n", __func__);

kfree(dir);
return err;
}
Expand Down Expand Up @@ -679,8 +665,6 @@ void xenbus_probe(struct work_struct *unused)
{
xenstored_ready = 1;

printk(KERN_CRIT "xenbus_probe wake_waiting\n");

/* Notify others that xenstore is up */
blocking_notifier_call_chain(&xenstore_chain, 0, NULL);
}
Expand Down Expand Up @@ -776,7 +760,6 @@ static int __init xenbus_init(void)
proc_mkdir("xen", NULL);
#endif

printk(KERN_CRIT "%s ok\n", __func__);
return 0;

out_error:
Expand Down

0 comments on commit a39bda2

Please sign in to comment.