Skip to content

Commit

Permalink
firmware: arm_scmi: Add clock management to the SCMI power domain
Browse files Browse the repository at this point in the history
Clocks requiring non-atomic contexts are supported by the generic clock
PM layer since commit 0bfa082 ("PM: clk: make PM clock layer
compatible with clocks that must sleep"). That means we can have
SCMI-based clocks be managed by the SCMI power domain now.

Link: https://lore.kernel.org/r/5q88n947-pon-4940-3or6-s54o4r361o5s@onlyvoer.pbz
Tested-by: Dien Pham <dien.pham.ry@renesas.com>
Reviewed-by: Gaku Inami <gaku.inami.xh@renesas.com>
Signed-off-by: Nicolas Pitre <npitre@baylibre.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
  • Loading branch information
Nicolas Pitre authored and Sudeep Holla committed May 11, 2021
1 parent 6efb943 commit a3b884c
Showing 1 changed file with 26 additions and 0 deletions.
26 changes: 26 additions & 0 deletions drivers/firmware/arm_scmi/scmi_pm_domain.c
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#include <linux/err.h>
#include <linux/io.h>
#include <linux/module.h>
#include <linux/pm_clock.h>
#include <linux/pm_domain.h>
#include <linux/scmi_protocol.h>

Expand Down Expand Up @@ -52,6 +53,27 @@ static int scmi_pd_power_off(struct generic_pm_domain *domain)
return scmi_pd_power(domain, false);
}

static int scmi_pd_attach_dev(struct generic_pm_domain *pd, struct device *dev)
{
int ret;

ret = pm_clk_create(dev);
if (ret)
return ret;

ret = of_pm_clk_add_clks(dev);
if (ret >= 0)
return 0;

pm_clk_destroy(dev);
return ret;
}

static void scmi_pd_detach_dev(struct generic_pm_domain *pd, struct device *dev)
{
pm_clk_destroy(dev);
}

static int scmi_pm_domain_probe(struct scmi_device *sdev)
{
int num_domains, i;
Expand Down Expand Up @@ -102,6 +124,10 @@ static int scmi_pm_domain_probe(struct scmi_device *sdev)
scmi_pd->genpd.name = scmi_pd->name;
scmi_pd->genpd.power_off = scmi_pd_power_off;
scmi_pd->genpd.power_on = scmi_pd_power_on;
scmi_pd->genpd.attach_dev = scmi_pd_attach_dev;
scmi_pd->genpd.detach_dev = scmi_pd_detach_dev;
scmi_pd->genpd.flags = GENPD_FLAG_PM_CLK |
GENPD_FLAG_ACTIVE_WAKEUP;

pm_genpd_init(&scmi_pd->genpd, NULL,
state == SCMI_POWER_STATE_GENERIC_OFF);
Expand Down

0 comments on commit a3b884c

Please sign in to comment.