Skip to content

Commit

Permalink
af-packet: fix oops when socket is not present
Browse files Browse the repository at this point in the history
Due to a NULL dereference, the following patch is causing oops
in normal trafic condition:

commit c0de08d
Author: Eric Leblond <eric@regit.org>
Date:   Thu Aug 16 22:02:58 2012 +0000

    af_packet: don't emit packet on orig fanout group

This buggy patch was a feature fix and has reached most stable
branches.

When skb->sk is NULL and when packet fanout is used, there is a
crash in match_fanout_group where skb->sk is accessed.
This patch fixes the issue by returning false as soon as the
socket is NULL: this correspond to the wanted behavior because
the kernel as to resend the skb to all the listening socket in
this case.

Signed-off-by: Eric Leblond <eric@regit.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Eric Leblond authored and David S. Miller committed Nov 7, 2012
1 parent 3015f3d commit a3d744e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/core/dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -1666,7 +1666,7 @@ static inline int deliver_skb(struct sk_buff *skb,

static inline bool skb_loop_sk(struct packet_type *ptype, struct sk_buff *skb)
{
if (ptype->af_packet_priv == NULL)
if (!ptype->af_packet_priv || !skb->sk)
return false;

if (ptype->id_match)
Expand Down

0 comments on commit a3d744e

Please sign in to comment.