Skip to content

Commit

Permalink
wifi: mac80211: fix memory leak in ieee80211_mgd_assoc_ml_reconf()
Browse files Browse the repository at this point in the history
Free the "data" allocation before returning on this error path.

Fixes: 36e05b0 ("wifi: mac80211: Support dynamic link addition and removal")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/7ad826a7-7651-48e7-9589-7d2dc17417c2@stanley.mountain
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
  • Loading branch information
Dan Carpenter authored and Johannes Berg committed Jan 15, 2025
1 parent 295adaf commit a4058dc
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions net/mac80211/mlme.c
Original file line number Diff line number Diff line change
@@ -10273,8 +10273,10 @@ int ieee80211_mgd_assoc_ml_reconf(struct ieee80211_sub_if_data *sdata,
* on which the request was received.
*/
skb = ieee80211_build_ml_reconf_req(sdata, data, rem_links);
if (!skb)
return -ENOMEM;
if (!skb) {
err = -ENOMEM;
goto err_free;
}

if (rem_links) {
u16 new_dormant_links = sdata->vif.dormant_links & ~rem_links;

0 comments on commit a4058dc

Please sign in to comment.