Skip to content

Commit

Permalink
Documentation: ACPI: Direct references are allowed to devices only
Browse files Browse the repository at this point in the history
In ACPI it is possible to make references to device objects only,
not to other objects inside a device.

In practice this means that hierarchical data extension targets
must be in parentheses to make them strings, or an ACPICA warning
will be produced.

Reported-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
[ rjw: Changelog ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
Sakari Ailus authored and Rafael J. Wysocki committed May 13, 2019
1 parent 5695f51 commit a423bd8
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ the ANOD object which is also the final target node of the reference.
Name (_DSD, Package () {
ToUUID("dbb8e3e6-5886-4ba6-8795-1319f52a966b"),
Package () {
Package () { "node@0", NOD0 },
Package () { "node@1", NOD1 },
Package () { "node@0", "NOD0" },
Package () { "node@1", "NOD1" },
}
})
Name (NOD0, Package() {
Expand All @@ -58,7 +58,7 @@ the ANOD object which is also the final target node of the reference.
Name (NOD1, Package() {
ToUUID("dbb8e3e6-5886-4ba6-8795-1319f52a966b"),
Package () {
Package () { "anothernode", ANOD },
Package () { "anothernode", "ANOD" },
}
})
Name (ANOD, Package() {
Expand Down
12 changes: 6 additions & 6 deletions Documentation/firmware-guide/acpi/dsd/graph.rst
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ with "port" and must be followed by the "@" character and the number of the
port as its key. The target object it refers to should be called "PRTX", where
"X" is the number of the port. An example of such a package would be::

Package() { "port@4", PRT4 }
Package() { "port@4", "PRT4" }

Further on, endpoints are located under the port nodes. The hierarchical
data extension key of the endpoint nodes must begin with
Expand All @@ -54,7 +54,7 @@ endpoint. The object it refers to should be called "EPXY", where "X" is the
number of the port and "Y" is the number of the endpoint. An example of such a
package would be::

Package() { "endpoint@0", EP40 }
Package() { "endpoint@0", "EP40" }

Each port node contains a property extension key "port", the value of which is
the number of the port. Each endpoint is similarly numbered with a property
Expand Down Expand Up @@ -91,7 +91,7 @@ A simple example of this is show below::
},
ToUUID("dbb8e3e6-5886-4ba6-8795-1319f52a966b"),
Package () {
Package () { "port@0", PRT0 },
Package () { "port@0", "PRT0" },
}
})
Name (PRT0, Package() {
Expand All @@ -101,7 +101,7 @@ A simple example of this is show below::
},
ToUUID("dbb8e3e6-5886-4ba6-8795-1319f52a966b"),
Package () {
Package () { "endpoint@0", EP00 },
Package () { "endpoint@0", "EP00" },
}
})
Name (EP00, Package() {
Expand All @@ -121,7 +121,7 @@ A simple example of this is show below::
Name (_DSD, Package () {
ToUUID("dbb8e3e6-5886-4ba6-8795-1319f52a966b"),
Package () {
Package () { "port@4", PRT4 },
Package () { "port@4", "PRT4" },
}
})

Expand All @@ -132,7 +132,7 @@ A simple example of this is show below::
},
ToUUID("dbb8e3e6-5886-4ba6-8795-1319f52a966b"),
Package () {
Package () { "endpoint@0", EP40 },
Package () { "endpoint@0", "EP40" },
}
})

Expand Down

0 comments on commit a423bd8

Please sign in to comment.