Skip to content

Commit

Permalink
sctp: pass a kernel pointer to sctp_setsockopt_reuse_port
Browse files Browse the repository at this point in the history
Use the kernel pointer that sctp_setsockopt has available instead of
directly handling the user pointer.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Christoph Hellwig authored and David S. Miller committed Jul 20, 2020
1 parent 5b8d3b2 commit a426246
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions net/sctp/socket.c
Original file line number Diff line number Diff line change
Expand Up @@ -4214,11 +4214,9 @@ static int sctp_setsockopt_interleaving_supported(struct sock *sk,
return 0;
}

static int sctp_setsockopt_reuse_port(struct sock *sk, char __user *optval,
static int sctp_setsockopt_reuse_port(struct sock *sk, int *val,
unsigned int optlen)
{
int val;

if (!sctp_style(sk, TCP))
return -EOPNOTSUPP;

Expand All @@ -4228,10 +4226,7 @@ static int sctp_setsockopt_reuse_port(struct sock *sk, char __user *optval,
if (optlen < sizeof(int))
return -EINVAL;

if (get_user(val, (int __user *)optval))
return -EFAULT;

sctp_sk(sk)->reuse = !!val;
sctp_sk(sk)->reuse = !!*val;

return 0;
}
Expand Down Expand Up @@ -4645,7 +4640,7 @@ static int sctp_setsockopt(struct sock *sk, int level, int optname,
optlen);
break;
case SCTP_REUSE_PORT:
retval = sctp_setsockopt_reuse_port(sk, optval, optlen);
retval = sctp_setsockopt_reuse_port(sk, kopt, optlen);
break;
case SCTP_EVENT:
retval = sctp_setsockopt_event(sk, optval, optlen);
Expand Down

0 comments on commit a426246

Please sign in to comment.