Skip to content

Commit

Permalink
ARM: virt: Avoid bx instruction for compatibility with <=ARMv4
Browse files Browse the repository at this point in the history
Non-T variants of ARMv4 do not support the bx instruction.

However, __hyp_stub_install is always called from the same
instruction set used to build the bulk of the kernel, so bx should
not be necessary.

This patch uses the traditional "mov pc" instead of bx.

Cc: <stable@vger.kernel.org>
Signed-off-by: Dave Martin <dave.martin@linaro.org>
[will: fixed up remaining bx instruction]
Signed-off-by: Will Deacon <will.deacon@arm.com>
  • Loading branch information
Dave Martin authored and Will Deacon committed Jan 10, 2013
1 parent 9931fac commit a4a12e0
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions arch/arm/kernel/hyp-stub.S
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ ENTRY(__hyp_stub_install_secondary)
* immediately.
*/
compare_cpu_mode_with_primary r4, r5, r6, r7
bxne lr
movne pc, lr

/*
* Once we have given up on one CPU, we do not try to install the
Expand All @@ -111,7 +111,7 @@ ENTRY(__hyp_stub_install_secondary)
*/

cmp r4, #HYP_MODE
bxne lr @ give up if the CPU is not in HYP mode
movne pc, lr @ give up if the CPU is not in HYP mode

/*
* Configure HSCTLR to set correct exception endianness/instruction set
Expand Down Expand Up @@ -200,7 +200,7 @@ ENDPROC(__hyp_get_vectors)
@ fall through
ENTRY(__hyp_set_vectors)
__HVC(0)
bx lr
mov pc, lr
ENDPROC(__hyp_set_vectors)

#ifndef ZIMAGE
Expand Down

0 comments on commit a4a12e0

Please sign in to comment.