Skip to content

Commit

Permalink
ALSA: line6: fix ifnullfree.cocci warnings
Browse files Browse the repository at this point in the history
sound/usb/line6/driver.c:484:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

 NULL check before some freeing functions is not needed.

 Based on checkpatch warning
 "kfree(NULL) is safe this check is probably not required"
 and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

CC: Andrej Krutak <dev@andree.sk>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
kbuild test robot authored and Takashi Iwai committed Sep 20, 2016
1 parent a16039c commit a4bc746
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions sound/usb/line6/driver.c
Original file line number Diff line number Diff line change
Expand Up @@ -480,8 +480,7 @@ static void line6_destruct(struct snd_card *card)
/* Free buffer memory first. We cannot depend on the existence of private
* data from the (podhd) module, it may be gone already during this call
*/
if (line6->buffer_message)
kfree(line6->buffer_message);
kfree(line6->buffer_message);

kfree(line6->buffer_listen);

Expand Down

0 comments on commit a4bc746

Please sign in to comment.