Skip to content

Commit

Permalink
coresight-tpda: Change qcom,dsb-element-size to qcom,dsb-elem-bits
Browse files Browse the repository at this point in the history
Change qcom,dsb-element-size to qcom,dsb-elem-bits as the unit is bit.
When use "-bits" suffix, the type of the property is u32 from
property-units.yaml, so use fwnode_property_read_u32 to read the
property.

Fixes: 57e7235 ("coresight-tpda: Add DSB dataset support")
Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
Link: https://lore.kernel.org/r/20240218094322.22470-3-quic_jinlmao@quicinc.com
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
  • Loading branch information
Mao Jinlong authored and Suzuki K Poulose committed Feb 27, 2024
1 parent 7f6860e commit a4f3057
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions drivers/hwtracing/coresight/coresight-tpda.c
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ static int tpdm_read_element_size(struct tpda_drvdata *drvdata,
struct tpdm_drvdata *tpdm_data = dev_get_drvdata(csdev->dev.parent);

if (tpdm_has_dsb_dataset(tpdm_data)) {
rc = fwnode_property_read_u8(dev_fwnode(csdev->dev.parent),
"qcom,dsb-element-size", &drvdata->dsb_esize);
rc = fwnode_property_read_u32(dev_fwnode(csdev->dev.parent),
"qcom,dsb-element-bits", &drvdata->dsb_esize);
}
if (tpdm_has_cmb_dataset(tpdm_data)) {
rc = fwnode_property_read_u32(dev_fwnode(csdev->dev.parent),
Expand Down
2 changes: 1 addition & 1 deletion drivers/hwtracing/coresight/coresight-tpda.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ struct tpda_drvdata {
struct coresight_device *csdev;
spinlock_t spinlock;
u8 atid;
u8 dsb_esize;
u32 dsb_esize;
u32 cmb_esize;
};

Expand Down

0 comments on commit a4f3057

Please sign in to comment.