Skip to content

Commit

Permalink
PCI: Cache PRI and PASID bits in pci_dev
Browse files Browse the repository at this point in the history
Device drivers need to check if an IOMMU enabled ATS, PRI and PASID in
order to know when they can use the SVM API.  Cache PRI and PASID bits in
the pci_dev structure, similarly to what is currently done for ATS.

Signed-off-by: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
  • Loading branch information
Jean-Philippe Brucker authored and Bjorn Helgaas committed May 30, 2017
1 parent 2ea659a commit a4f4fa6
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 0 deletions.
23 changes: 23 additions & 0 deletions drivers/pci/ats.c
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,9 @@ int pci_enable_pri(struct pci_dev *pdev, u32 reqs)
u32 max_requests;
int pos;

if (WARN_ON(pdev->pri_enabled))
return -EBUSY;

pos = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_PRI);
if (!pos)
return -EINVAL;
Expand All @@ -170,6 +173,8 @@ int pci_enable_pri(struct pci_dev *pdev, u32 reqs)
control |= PCI_PRI_CTRL_ENABLE;
pci_write_config_word(pdev, pos + PCI_PRI_CTRL, control);

pdev->pri_enabled = 1;

return 0;
}
EXPORT_SYMBOL_GPL(pci_enable_pri);
Expand All @@ -185,13 +190,18 @@ void pci_disable_pri(struct pci_dev *pdev)
u16 control;
int pos;

if (WARN_ON(!pdev->pri_enabled))
return;

pos = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_PRI);
if (!pos)
return;

pci_read_config_word(pdev, pos + PCI_PRI_CTRL, &control);
control &= ~PCI_PRI_CTRL_ENABLE;
pci_write_config_word(pdev, pos + PCI_PRI_CTRL, control);

pdev->pri_enabled = 0;
}
EXPORT_SYMBOL_GPL(pci_disable_pri);

Expand All @@ -207,6 +217,9 @@ int pci_reset_pri(struct pci_dev *pdev)
u16 control;
int pos;

if (WARN_ON(pdev->pri_enabled))
return -EBUSY;

pos = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_PRI);
if (!pos)
return -EINVAL;
Expand Down Expand Up @@ -239,6 +252,9 @@ int pci_enable_pasid(struct pci_dev *pdev, int features)
u16 control, supported;
int pos;

if (WARN_ON(pdev->pasid_enabled))
return -EBUSY;

pos = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_PASID);
if (!pos)
return -EINVAL;
Expand All @@ -259,6 +275,8 @@ int pci_enable_pasid(struct pci_dev *pdev, int features)

pci_write_config_word(pdev, pos + PCI_PASID_CTRL, control);

pdev->pasid_enabled = 1;

return 0;
}
EXPORT_SYMBOL_GPL(pci_enable_pasid);
Expand All @@ -273,11 +291,16 @@ void pci_disable_pasid(struct pci_dev *pdev)
u16 control = 0;
int pos;

if (WARN_ON(!pdev->pasid_enabled))
return;

pos = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_PASID);
if (!pos)
return;

pci_write_config_word(pdev, pos + PCI_PASID_CTRL, control);

pdev->pasid_enabled = 0;
}
EXPORT_SYMBOL_GPL(pci_disable_pasid);

Expand Down
2 changes: 2 additions & 0 deletions include/linux/pci.h
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,8 @@ struct pci_dev {
unsigned int msix_enabled:1;
unsigned int ari_enabled:1; /* ARI forwarding */
unsigned int ats_enabled:1; /* Address Translation Service */
unsigned int pasid_enabled:1; /* Process Address Space ID */
unsigned int pri_enabled:1; /* Page Request Interface */
unsigned int is_managed:1;
unsigned int needs_freset:1; /* Dev requires fundamental reset */
unsigned int state_saved:1;
Expand Down

0 comments on commit a4f4fa6

Please sign in to comment.