Skip to content

Commit

Permalink
keyspan: fix oops
Browse files Browse the repository at this point in the history
If we get a data URB back from the hardware after we have put the tty to
bed we go kaboom.  Fortunately all we need to do is process the URB without
trying to ram its contents down the throat of an ex-tty.

Signed-off-by: Alan Cox <alan@redhat.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@akpm@linux-foundation.org>
  • Loading branch information
Alan Cox authored and Linus Torvalds committed Jan 22, 2008
1 parent 1fc3858 commit a5569a5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/usb/serial/keyspan.c
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ static void usa26_indat_callback(struct urb *urb)

port = (struct usb_serial_port *) urb->context;
tty = port->tty;
if (urb->actual_length) {
if (tty && urb->actual_length) {
/* 0x80 bit is error flag */
if ((data[0] & 0x80) == 0) {
/* no errors on individual bytes, only possible overrun err*/
Expand Down

0 comments on commit a5569a5

Please sign in to comment.