Skip to content

Commit

Permalink
iommu/sprd: Fix parameter type warning
Browse files Browse the repository at this point in the history
The second parameter of clk_get_optional() is "const char *", so use NULL
instead of integer 0 to fix a sparse warning like:

">> drivers/iommu/sprd-iommu.c:456:42: sparse: sparse: Using plain integer as NULL pointer"

Also this patch changes to use the resource-managed variant of
clk_get_optional(), then there's no need to add clk_put() which
is missed in the current driver.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
Link: https://lore.kernel.org/r/20210331031645.1001913-1-zhang.lyra@gmail.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
  • Loading branch information
Chunyan Zhang authored and Joerg Roedel committed Apr 7, 2021
1 parent 0bb868e commit a56af06
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/iommu/sprd-iommu.c
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ static int sprd_iommu_clk_enable(struct sprd_iommu_device *sdev)
{
struct clk *eb;

eb = clk_get_optional(sdev->dev, 0);
eb = devm_clk_get_optional(sdev->dev, NULL);
if (!eb)
return 0;

Expand Down

0 comments on commit a56af06

Please sign in to comment.