Skip to content

Commit

Permalink
net: dsa: lan9303: make lan9303_handle_reset() a void function
Browse files Browse the repository at this point in the history
lan9303_handle_reset never returns anything other than success.
So there's not need for it to return an error code.

Signed-off-by: Phil Reid <preid@electromag.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Phil Reid authored and David S. Miller committed Jan 15, 2018
1 parent 9f239fe commit a57d476
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions drivers/net/dsa/lan9303-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -817,18 +817,16 @@ static void lan9303_bridge_ports(struct lan9303 *chip)
lan9303_alr_add_port(chip, eth_stp_addr, 0, true);
}

static int lan9303_handle_reset(struct lan9303 *chip)
static void lan9303_handle_reset(struct lan9303 *chip)
{
if (!chip->reset_gpio)
return 0;
return;

if (chip->reset_duration != 0)
msleep(chip->reset_duration);

/* release (deassert) reset and activate the device */
gpiod_set_value_cansleep(chip->reset_gpio, 0);

return 0;
}

/* stop processing packets for all ports */
Expand Down Expand Up @@ -1328,9 +1326,7 @@ int lan9303_probe(struct lan9303 *chip, struct device_node *np)

lan9303_probe_reset_gpio(chip, np);

ret = lan9303_handle_reset(chip);
if (ret)
return ret;
lan9303_handle_reset(chip);

ret = lan9303_check_device(chip);
if (ret)
Expand Down

0 comments on commit a57d476

Please sign in to comment.