Skip to content

Commit

Permalink
libcxgbi: Handle dst_get_neighbour_noref() returning NULL.
Browse files Browse the repository at this point in the history 
Signed-off-by: David S. Miller <davem@davemloft.net>
Acked-by: Roland Dreier <roland@purestorage.com>
  • Loading branch information
David Miller committed Dec 5, 2011
1 parent 3786cf1 commit a58b61e
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions drivers/scsi/cxgbi/libcxgbi.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,7 @@ static struct cxgbi_sock *cxgbi_check_route(struct sockaddr *dst_addr)
struct net_device *ndev;
struct cxgbi_device *cdev;
struct rtable *rt = NULL;
struct neighbour *n;
struct flowi4 fl4;
struct cxgbi_sock *csk = NULL;
unsigned int mtu = 0;
Expand All @@ -493,7 +494,12 @@ static struct cxgbi_sock *cxgbi_check_route(struct sockaddr *dst_addr)
goto err_out;
}
dst = &rt->dst;
ndev = dst_get_neighbour_noref(dst)->dev;
n = dst_get_neighbour_noref(dst);
if (!n) {
err = -ENODEV;
goto rel_rt;
}
ndev = n->dev;

if (rt->rt_flags & (RTCF_MULTICAST | RTCF_BROADCAST)) {
pr_info("multi-cast route %pI4, port %u, dev %s.\n",
Expand All @@ -507,7 +513,7 @@ static struct cxgbi_sock *cxgbi_check_route(struct sockaddr *dst_addr)
ndev = ip_dev_find(&init_net, daddr->sin_addr.s_addr);
mtu = ndev->mtu;
pr_info("rt dev %s, loopback -> %s, mtu %u.\n",
dst_get_neighbour_noref(dst)->dev->name, ndev->name, mtu);
n->dev->name, ndev->name, mtu);
}

cdev = cxgbi_device_find_by_netdev(ndev, &port);
Expand Down

0 comments on commit a58b61e

Please sign in to comment.