Skip to content

Commit

Permalink
ARM: imx: pllv1: Fix PLL calculation for i.MX27
Browse files Browse the repository at this point in the history
MFN bit 9 on i.MX27 has a different meaning than in other SOCs. This
is a just sign bit. This patch makes different calculation for i.MX27.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
  • Loading branch information
Alexander Shiyan authored and Shawn Guo committed Dec 31, 2013
1 parent 630a212 commit a594790
Showing 1 changed file with 19 additions and 4 deletions.
23 changes: 19 additions & 4 deletions arch/arm/mach-imx/clk-pllv1.c
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,23 @@
*
* PLL clock version 1, found on i.MX1/21/25/27/31/35
*/

#define MFN_BITS (10)
#define MFN_SIGN (BIT(MFN_BITS - 1))
#define MFN_MASK (MFN_SIGN - 1)

struct clk_pllv1 {
struct clk_hw hw;
void __iomem *base;
};

#define to_clk_pllv1(clk) (container_of(clk, struct clk_pllv1, clk))

static inline bool mfn_is_negative(unsigned int mfn)
{
return !cpu_is_mx1() && !cpu_is_mx21() && (mfn & MFN_SIGN);
}

static unsigned long clk_pllv1_recalc_rate(struct clk_hw *hw,
unsigned long parent_rate)
{
Expand Down Expand Up @@ -58,10 +68,15 @@ static unsigned long clk_pllv1_recalc_rate(struct clk_hw *hw,

/*
* On all i.MXs except i.MX1 and i.MX21 mfn is a 10bit
* 2's complements number
* 2's complements number.
* On i.MX27 the bit 9 is the sign bit.
*/
if (!cpu_is_mx1() && !cpu_is_mx21() && mfn >= 0x200)
mfn_abs = 0x400 - mfn;
if (mfn_is_negative(mfn)) {
if (cpu_is_mx27())
mfn_abs = mfn & MFN_MASK;
else
mfn_abs = BIT(MFN_BITS) - mfn;
}

rate = parent_rate * 2;
rate /= pd + 1;
Expand All @@ -70,7 +85,7 @@ static unsigned long clk_pllv1_recalc_rate(struct clk_hw *hw,

do_div(ll, mfd + 1);

if (!cpu_is_mx1() && !cpu_is_mx21() && mfn >= 0x200)
if (mfn_is_negative(mfn))
ll = -ll;

ll = (rate * mfi) + ll;
Expand Down

0 comments on commit a594790

Please sign in to comment.