Skip to content

Commit

Permalink
cxgb3 - Firmware update
Browse files Browse the repository at this point in the history
Update firmware version.
Allow the driver to be up and running with older FW image

Signed-off-by: Divy Le Ray <divy@chelsio.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
  • Loading branch information
Divy Le Ray authored and David S. Miller committed Oct 10, 2007
1 parent 34c6417 commit a5a3b46
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 11 deletions.
2 changes: 1 addition & 1 deletion drivers/net/cxgb3/common.h
Original file line number Diff line number Diff line change
Expand Up @@ -690,7 +690,7 @@ int t3_read_flash(struct adapter *adapter, unsigned int addr,
unsigned int nwords, u32 *data, int byte_oriented);
int t3_load_fw(struct adapter *adapter, const u8 * fw_data, unsigned int size);
int t3_get_fw_version(struct adapter *adapter, u32 *vers);
int t3_check_fw_version(struct adapter *adapter);
int t3_check_fw_version(struct adapter *adapter, int *must_load);
int t3_init_hw(struct adapter *adapter, u32 fw_params);
void mac_prep(struct cmac *mac, struct adapter *adapter, int index);
void early_hw_init(struct adapter *adapter, const struct adapter_info *ai);
Expand Down
9 changes: 5 additions & 4 deletions drivers/net/cxgb3/cxgb3_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -797,11 +797,12 @@ static int cxgb_up(struct adapter *adap)
int must_load;

if (!(adap->flags & FULL_INIT_DONE)) {
err = t3_check_fw_version(adap);
if (err == -EINVAL)
err = t3_check_fw_version(adap, &must_load);
if (err == -EINVAL) {
err = upgrade_fw(adap);
if (err)
goto out;
if (err && must_load)
goto out;
}

err = t3_check_tpsram_version(adap, &must_load);
if (err == -EINVAL) {
Expand Down
20 changes: 15 additions & 5 deletions drivers/net/cxgb3/t3_hw.c
Original file line number Diff line number Diff line change
Expand Up @@ -960,16 +960,18 @@ int t3_get_fw_version(struct adapter *adapter, u32 *vers)
/**
* t3_check_fw_version - check if the FW is compatible with this driver
* @adapter: the adapter
*
* @must_load: set to 1 if loading a new FW image is required
* Checks if an adapter's FW is compatible with the driver. Returns 0
* if the versions are compatible, a negative error otherwise.
*/
int t3_check_fw_version(struct adapter *adapter)
int t3_check_fw_version(struct adapter *adapter, int *must_load)
{
int ret;
u32 vers;
unsigned int type, major, minor;

*must_load = 1;
ret = t3_get_fw_version(adapter, &vers);
if (ret)
return ret;
Expand All @@ -982,9 +984,17 @@ int t3_check_fw_version(struct adapter *adapter)
minor == FW_VERSION_MINOR)
return 0;

CH_ERR(adapter, "found wrong FW version(%u.%u), "
"driver needs version %u.%u\n", major, minor,
FW_VERSION_MAJOR, FW_VERSION_MINOR);
if (major != FW_VERSION_MAJOR)
CH_ERR(adapter, "found wrong FW version(%u.%u), "
"driver needs version %u.%u\n", major, minor,
FW_VERSION_MAJOR, FW_VERSION_MINOR);
else {
*must_load = 0;
CH_WARN(adapter, "found wrong FW minor version(%u.%u), "
"driver compiled for version %u.%u\n", major, minor,
FW_VERSION_MAJOR, FW_VERSION_MINOR);
}

return -EINVAL;
}

Expand Down
2 changes: 1 addition & 1 deletion drivers/net/cxgb3/version.h
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,6 @@

/* Firmware version */
#define FW_VERSION_MAJOR 4
#define FW_VERSION_MINOR 3
#define FW_VERSION_MINOR 6
#define FW_VERSION_MICRO 0
#endif /* __CHELSIO_VERSION_H */

0 comments on commit a5a3b46

Please sign in to comment.