Skip to content

Commit

Permalink
kbuild: do not sort after reading modules.order
Browse files Browse the repository at this point in the history 
modules.order lists modules in the deterministic order (that is why
"modules order"), and there is no duplication in the list.

$(sort ) is pointless.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
  • Loading branch information
Masahiro Yamada committed Dec 13, 2022
1 parent fccb3d3 commit a5db80c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion scripts/Makefile.modfinal
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ include $(srctree)/scripts/Kbuild.include
include $(srctree)/scripts/Makefile.lib

# find all modules listed in modules.order
modules := $(sort $(shell cat $(MODORDER)))
modules := $(shell cat $(MODORDER))

__modfinal: $(modules)
@:
Expand Down
2 changes: 1 addition & 1 deletion scripts/Makefile.modinst
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ __modinst:
include include/config/auto.conf
include $(srctree)/scripts/Kbuild.include

modules := $(sort $(shell cat $(MODORDER)))
modules := $(shell cat $(MODORDER))

ifeq ($(KBUILD_EXTMOD),)
dst := $(MODLIB)/kernel
Expand Down

0 comments on commit a5db80c

Please sign in to comment.