Skip to content

Commit

Permalink
hsa/radeon: Don't verify cksum when parsing CRAT table
Browse files Browse the repository at this point in the history
This patch removes the checksum verification done when
parsing a CRAT table. The verification was both erronous and
redundant, as it is done by another piece of kernel code.

Signed-off-by: Oded Gabbay <oded.gabbay@amd.com>
  • Loading branch information
Oded Gabbay committed Jun 26, 2014
1 parent c0ec80b commit a5e7e46
Showing 1 changed file with 2 additions and 27 deletions.
29 changes: 2 additions & 27 deletions drivers/gpu/hsa/radeon/kfd_topology.c
Original file line number Diff line number Diff line change
Expand Up @@ -38,21 +38,6 @@ static struct kfd_system_properties sys_props;

static DECLARE_RWSEM(topology_lock);


static uint8_t checksum_image(const void *buf, size_t len)
{
uint8_t *p = (uint8_t *)buf;
uint8_t sum = 0;

if (!buf)
return 0;

while (len-- > 0)
sum += *p++;

return sum;
}

struct kfd_dev *radeon_kfd_device_by_id(uint32_t gpu_id)
{
struct kfd_topology_device *top_dev;
Expand Down Expand Up @@ -97,9 +82,9 @@ static int kfd_topology_get_crat_acpi(void *crat_image, size_t *size)
if (!size)
return -EINVAL;

/*
/*
* Fetch the CRAT table from ACPI
*/
*/
status = acpi_get_table(CRAT_SIGNATURE, 0, &crat_table);
if (status == AE_NOT_FOUND) {
pr_warn("CRAT table not found\n");
Expand All @@ -110,16 +95,6 @@ static int kfd_topology_get_crat_acpi(void *crat_image, size_t *size)
return -EINVAL;
}

/*
* The checksum of the table should be verified
*/
if (checksum_image(crat_table, crat_table->length) ==
crat_table->checksum) {
pr_err("Bad checksum for the CRAT table\n");
return -EINVAL;
}


if (*size >= crat_table->length && crat_image != 0)
memcpy(crat_image, crat_table, crat_table->length);

Expand Down

0 comments on commit a5e7e46

Please sign in to comment.