Skip to content

Commit

Permalink
thermal/debugfs: Make tze_seq_show() skip invalid trips and trips wit…
Browse files Browse the repository at this point in the history
…h no stats

Currently, tze_seq_show() output includes all of the trips in the zone
except for critical ones, including invalid trips and trips with no stats
which is confusing.

Make it skip the trips for which there is not mitigation information.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
  • Loading branch information
Rafael J. Wysocki committed Apr 24, 2024
1 parent 8dff6e8 commit a6258fd
Showing 1 changed file with 16 additions and 6 deletions.
22 changes: 16 additions & 6 deletions drivers/thermal/thermal_debugfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -754,6 +754,11 @@ static int tze_seq_show(struct seq_file *s, void *v)

for_each_trip_desc(tz, td) {
const struct thermal_trip *trip = &td->trip;
struct trip_stats *trip_stats;

/* Skip invalid trips. */
if (trip->temperature == THERMAL_TEMP_INVALID)
continue;

/*
* There is no possible mitigation happening at the
Expand All @@ -763,24 +768,29 @@ static int tze_seq_show(struct seq_file *s, void *v)
if (trip->type == THERMAL_TRIP_CRITICAL)
continue;

trip_id = thermal_zone_trip_id(tz, trip);
trip_stats = &tze->trip_stats[trip_id];

/* Skip trips without any stats. */
if (trip_stats->min > trip_stats->max)
continue;

if (trip->type == THERMAL_TRIP_PASSIVE)
type = "passive";
else if (trip->type == THERMAL_TRIP_ACTIVE)
type = "active";
else
type = "hot";

trip_id = thermal_zone_trip_id(tz, trip);

seq_printf(s, "| %*d | %*s | %*d | %*d | %*lld | %*d | %*d | %*d |\n",
4 , trip_id,
8, type,
9, trip->temperature,
9, trip->hysteresis,
10, ktime_to_ms(tze->trip_stats[trip_id].duration),
9, tze->trip_stats[trip_id].avg,
9, tze->trip_stats[trip_id].min,
9, tze->trip_stats[trip_id].max);
10, ktime_to_ms(trip_stats->duration),
9, trip_stats->avg,
9, trip_stats->min,
9, trip_stats->max);
}

return 0;
Expand Down

0 comments on commit a6258fd

Please sign in to comment.