Skip to content

Commit

Permalink
btrfs: fix uninitialized variable warning in run_one_async_start
Browse files Browse the repository at this point in the history
With -Wmaybe-uninitialized compiler complains about ret being possibly
uninitialized, which isn't possible as the WQ_ constants are set only
from our code, however we can handle the default case and get rid of the
warning.

The value is set to BLK_STS_IOERR so it does not issue any IO and could
be potentially detected, but this is basically a "cannot happen" error.
To catch any problems during development use the assert.

Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
[ set the error in default: ]
Signed-off-by: David Sterba <dsterba@suse.com>
  • Loading branch information
Josef Bacik authored and David Sterba committed Feb 13, 2023
1 parent cd30d3b commit a6ca692
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions fs/btrfs/disk-io.c
Original file line number Diff line number Diff line change
Expand Up @@ -717,6 +717,10 @@ static void run_one_async_start(struct btrfs_work *work)
ret = btrfs_submit_bio_start_direct_io(async->inode,
async->bio, async->dio_file_offset);
break;
default:
/* Can't happen so return something that would prevent the IO. */
ret = BLK_STS_IOERR;
ASSERT(0);
}
if (ret)
async->status = ret;
Expand Down

0 comments on commit a6ca692

Please sign in to comment.