Skip to content

Commit

Permalink
net: phy: remove gen10g_suspend and gen10g_resume
Browse files Browse the repository at this point in the history
phy_suspend() and phy_resume() are no-ops anyway if no callback is
defined. Therefore we don't need these stubs.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Heiner Kallweit authored and David S. Miller committed Mar 4, 2019
1 parent d7bed82 commit a6d0aa9
Showing 2 changed files with 0 additions and 16 deletions.
14 changes: 0 additions & 14 deletions drivers/net/phy/phy-c45.c
Original file line number Diff line number Diff line change
@@ -529,18 +529,6 @@ int gen10g_config_init(struct phy_device *phydev)
}
EXPORT_SYMBOL_GPL(gen10g_config_init);

int gen10g_suspend(struct phy_device *phydev)
{
return 0;
}
EXPORT_SYMBOL_GPL(gen10g_suspend);

int gen10g_resume(struct phy_device *phydev)
{
return 0;
}
EXPORT_SYMBOL_GPL(gen10g_resume);

struct phy_driver genphy_10g_driver = {
.phy_id = 0xffffffff,
.phy_id_mask = 0xffffffff,
@@ -550,6 +538,4 @@ struct phy_driver genphy_10g_driver = {
.features = PHY_10GBIT_FEATURES,
.config_aneg = gen10g_config_aneg,
.read_status = gen10g_read_status,
.suspend = gen10g_suspend,
.resume = gen10g_resume,
};
2 changes: 0 additions & 2 deletions include/linux/phy.h
Original file line number Diff line number Diff line change
@@ -1122,8 +1122,6 @@ int gen10g_config_aneg(struct phy_device *phydev);
int gen10g_read_status(struct phy_device *phydev);
int gen10g_no_soft_reset(struct phy_device *phydev);
int gen10g_config_init(struct phy_device *phydev);
int gen10g_suspend(struct phy_device *phydev);
int gen10g_resume(struct phy_device *phydev);

static inline int phy_read_status(struct phy_device *phydev)
{

0 comments on commit a6d0aa9

Please sign in to comment.