Skip to content

Commit

Permalink
net: ethernet: renesas: ravb_main: test clock rate to avoid division …
Browse files Browse the repository at this point in the history
…by 0

The clk API may return 0 on clk_get_rate, so we should check the result before
using it as a divisor.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Wolfram Sang authored and David S. Miller committed Apr 14, 2016
1 parent 60e1951 commit a6d3713
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/net/ethernet/renesas/ravb_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -1691,6 +1691,9 @@ static int ravb_set_gti(struct net_device *ndev)
rate = clk_get_rate(clk);
clk_put(clk);

if (!rate)
return -EINVAL;

inc = 1000000000ULL << 20;
do_div(inc, rate);

Expand Down

0 comments on commit a6d3713

Please sign in to comment.