Skip to content

Commit

Permalink
[PATCH] uml: hostfs: make hostfs= option work as a jail, as intended.
Browse files Browse the repository at this point in the history
When a given host directory is specified to be mounted both in hostfs=path1
and with mount option -o path2, we should give access to path1/path2, but this
does not happen.  Fix that in the simpler way.

Also, root_ino can be the empty string, since we use %s/%s as format.

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Acked-by: Jeff Dike <jdike@addtoit.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Paolo 'Blaisorblade' Giarrusso authored and Linus Torvalds committed Mar 8, 2007
1 parent bca2711 commit a6eb0be
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions fs/hostfs/hostfs_kern.c
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ struct dentry_operations hostfs_dentry_ops = {
};

/* Changed in hostfs_args before the kernel starts running */
static char *root_ino = "/";
static char *root_ino = "";
static int append = 0;

#define HOSTFS_SUPER_MAGIC 0x00c0ffee
Expand Down Expand Up @@ -947,15 +947,17 @@ static int hostfs_fill_sb_common(struct super_block *sb, void *d, int silent)
sb->s_magic = HOSTFS_SUPER_MAGIC;
sb->s_op = &hostfs_sbops;

if((data == NULL) || (*data == '\0'))
data = root_ino;
/* NULL is printed as <NULL> by sprintf: avoid that. */
if (data == NULL)
data = "";

err = -ENOMEM;
name = kmalloc(strlen(data) + 1, GFP_KERNEL);
name = kmalloc(strlen(root_ino) + 1
+ strlen(data) + 1, GFP_KERNEL);
if(name == NULL)
goto out;

strcpy(name, data);
sprintf(name, "%s/%s", root_ino, data);

root_inode = iget(sb, 0);
if(root_inode == NULL)
Expand Down

0 comments on commit a6eb0be

Please sign in to comment.