Skip to content

Commit

Permalink
Input: uinput - allow for 0/0 min/max on absolute axes.
Browse files Browse the repository at this point in the history
Some devices provide absolute axes with min/max of 0/0 (e.g. wacom's
ABS_MISC axis). Current uinput restrictions do not allow duplication of
these devices and require hacks in userspace to work around this.

If the kernel accepts physical devices with a min/max of 0/0, uinput
shouldn't disallow the same range.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
  • Loading branch information
Peter Hutterer authored and Dmitry Torokhov committed Mar 31, 2011
1 parent 170531b commit a718d79
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion drivers/input/misc/uinput.c
Original file line number Diff line number Diff line change
Expand Up @@ -302,10 +302,14 @@ static int uinput_validate_absbits(struct input_dev *dev)
int retval = 0;

for (cnt = 0; cnt < ABS_CNT; cnt++) {
int min, max;
if (!test_bit(cnt, dev->absbit))
continue;

if (input_abs_get_max(dev, cnt) <= input_abs_get_min(dev, cnt)) {
min = input_abs_get_min(dev, cnt);
max = input_abs_get_max(dev, cnt);

if ((min != 0 || max != 0) && max <= min) {
printk(KERN_DEBUG
"%s: invalid abs[%02x] min:%d max:%d\n",
UINPUT_NAME, cnt,
Expand Down

0 comments on commit a718d79

Please sign in to comment.