Skip to content

Commit

Permalink
usb: bdc: remove duplicated error message
Browse files Browse the repository at this point in the history
in case devm_platform_ioremap_resource() fails, that function already
prints a relevant error message which renders the driver's dev_err()
redundant. Let's remove the unnecessary message and, while at that,
also make sure to pass along the error value returned by
devm_platform_ioremap_resource() instead of always returning -ENOMEM.

Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>

[balbi@kernel.org : improved commit log]

Signed-off-by: Felipe Balbi <balbi@kernel.org>
  • Loading branch information
Tang Bin authored and Felipe Balbi committed Oct 2, 2020
1 parent ae7e861 commit a73abc2
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions drivers/usb/gadget/udc/bdc/bdc_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -510,10 +510,9 @@ static int bdc_probe(struct platform_device *pdev)
bdc->clk = clk;

bdc->regs = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(bdc->regs)) {
dev_err(dev, "ioremap error\n");
return -ENOMEM;
}
if (IS_ERR(bdc->regs))
return PTR_ERR(bdc->regs);

irq = platform_get_irq(pdev, 0);
if (irq < 0)
return irq;
Expand Down

0 comments on commit a73abc2

Please sign in to comment.