Skip to content

Commit

Permalink
ide: move ide_setup_pci_controller() call to ide_setup_pci_device[s]()
Browse files Browse the repository at this point in the history
There should be no functional changes caused by this patch.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
  • Loading branch information
Bartlomiej Zolnierkiewicz committed Jul 24, 2008
1 parent a95925a commit a742d6c
Showing 1 changed file with 9 additions and 5 deletions.
14 changes: 9 additions & 5 deletions drivers/ide/setup-pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -488,10 +488,6 @@ static int do_ide_setup_pci_device(struct pci_dev *dev,
{
int pciirq, ret;

ret = ide_setup_pci_controller(dev, d, noisy);
if (ret < 0)
goto out;

/*
* Can we trust the reported IRQ?
*/
Expand Down Expand Up @@ -534,6 +530,10 @@ int ide_setup_pci_device(struct pci_dev *dev, const struct ide_port_info *d)
hw_regs_t hw[4], *hws[] = { NULL, NULL, NULL, NULL };
int ret;

ret = ide_setup_pci_controller(dev, d, 1);
if (ret < 0)
goto out;

ret = do_ide_setup_pci_device(dev, d, 1);

if (ret >= 0) {
Expand All @@ -542,7 +542,7 @@ int ide_setup_pci_device(struct pci_dev *dev, const struct ide_port_info *d)

ret = ide_host_add(d, hws, NULL);
}

out:
return ret;
}
EXPORT_SYMBOL_GPL(ide_setup_pci_device);
Expand All @@ -555,6 +555,10 @@ int ide_setup_pci_devices(struct pci_dev *dev1, struct pci_dev *dev2,
hw_regs_t hw[4], *hws[] = { NULL, NULL, NULL, NULL };

for (i = 0; i < 2; i++) {
ret = ide_setup_pci_controller(pdev[i], d, !i);
if (ret < 0)
goto out;

ret = do_ide_setup_pci_device(pdev[i], d, !i);

/*
Expand Down

0 comments on commit a742d6c

Please sign in to comment.