Skip to content

Commit

Permalink
cpufreq: schedutil: remove stale comment
Browse files Browse the repository at this point in the history
After commit 794a56e (sched/cpufreq: Change the worker kthread to
SCHED_DEADLINE) schedutil kthreads are "ignored" for a clock frequency
selection point of view, so the potential corner case for RT tasks is not
possible at all now.

Remove the stale comment mentioning it.

Signed-off-by: Juri Lelli <juri.lelli@redhat.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
Juri Lelli authored and Rafael J. Wysocki committed May 9, 2018
1 parent 75bc37f commit a744490
Showing 1 changed file with 0 additions and 13 deletions.
13 changes: 0 additions & 13 deletions kernel/sched/cpufreq_schedutil.c
Original file line number Diff line number Diff line change
@@ -396,19 +396,6 @@ static void sugov_irq_work(struct irq_work *irq_work)

sg_policy = container_of(irq_work, struct sugov_policy, irq_work);

/*
* For RT tasks, the schedutil governor shoots the frequency to maximum.
* Special care must be taken to ensure that this kthread doesn't result
* in the same behavior.
*
* This is (mostly) guaranteed by the work_in_progress flag. The flag is
* updated only at the end of the sugov_work() function and before that
* the schedutil governor rejects all other frequency scaling requests.
*
* There is a very rare case though, where the RT thread yields right
* after the work_in_progress flag is cleared. The effects of that are
* neglected for now.
*/
kthread_queue_work(&sg_policy->worker, &sg_policy->work);
}

0 comments on commit a744490

Please sign in to comment.