Skip to content

Commit

Permalink
rtnetlink: Use nlmsg type RTM_NEWNEIGH from dflt fdb dump
Browse files Browse the repository at this point in the history
Change the dflt fdb dump handler to use RTM_NEWNEIGH to
be compatible with bridge dump routines.

The dump reply from the network driver handlers should
match the reply from bridge handler. The fact they were
not in the ixgbe case was effectively a bug. This patch
resolves it.

Applications that were not checking the nlmsg type will
continue to work. And now applications that do check
the type will work as expected.

Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
John Fastabend authored and David S. Miller committed Nov 3, 2012
1 parent 87f4d7c commit a7a558f
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion net/core/rtnetlink.c
Original file line number Diff line number Diff line change
Expand Up @@ -2192,7 +2192,8 @@ static int nlmsg_populate_fdb(struct sk_buff *skb,
goto skip;

err = nlmsg_populate_fdb_fill(skb, dev, ha->addr,
portid, seq, 0, NTF_SELF);
portid, seq,
RTM_NEWNEIGH, NTF_SELF);
if (err < 0)
return err;
skip:
Expand Down

0 comments on commit a7a558f

Please sign in to comment.