Skip to content

Commit

Permalink
ip6mr: remove stray rcu_read_unlock() from ip6_mr_forward()
Browse files Browse the repository at this point in the history
One rcu_read_unlock() should have been removed in blamed commit.

Fixes: 9b1c21d ("ip6mr: do not acquire mrt_lock while calling ip6_mr_forward()")
Reported-by: Vladimir Oltean <olteanv@gmail.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Link: https://lore.kernel.org/r/20220725200554.2563581-1-eric.dumazet@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Eric Dumazet authored and Jakub Kicinski committed Jul 27, 2022
1 parent 48c022d commit a7e555d
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions net/ipv6/ip6mr.c
Original file line number Diff line number Diff line change
Expand Up @@ -2133,10 +2133,8 @@ static void ip6_mr_forward(struct net *net, struct mr_table *mrt,
*/
cache_proxy = mr_mfc_find_any_parent(mrt, vif);
if (cache_proxy &&
cache_proxy->_c.mfc_un.res.ttls[true_vifi] < 255) {
rcu_read_unlock();
cache_proxy->_c.mfc_un.res.ttls[true_vifi] < 255)
goto forward;
}
}

/*
Expand Down

0 comments on commit a7e555d

Please sign in to comment.