Skip to content

Commit

Permalink
spi: spi-cavium-thunderx: Add missing pci_release_regions()
Browse files Browse the repository at this point in the history
The driver forgets to call pci_release_regions() in probe failure
and remove.
Add the missed calls to fix it.

Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Link: https://lore.kernel.org/r/20191206075500.18525-1-hslester96@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Chuhong Yuan authored and Mark Brown committed Dec 9, 2019
1 parent 5e9c523 commit a841e28
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/spi/spi-cavium-thunderx.c
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ static int thunderx_spi_probe(struct pci_dev *pdev,

error:
clk_disable_unprepare(p->clk);
pci_release_regions(pdev);
spi_master_put(master);
return ret;
}
Expand All @@ -96,6 +97,7 @@ static void thunderx_spi_remove(struct pci_dev *pdev)
return;

clk_disable_unprepare(p->clk);
pci_release_regions(pdev);
/* Put everything in a known state. */
writeq(0, p->register_base + OCTEON_SPI_CFG(p));
}
Expand Down

0 comments on commit a841e28

Please sign in to comment.