Skip to content

Commit

Permalink
drm: omapdrm: panel-lgphilips-lb035q02: Remove unused backlight GPIO
Browse files Browse the repository at this point in the history
The backlight GPIO was supported with platform data only. Now that the
driver only supports DT, the backlight GPIO is never initialized. Remove
it.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
  • Loading branch information
Laurent Pinchart authored and Tomi Valkeinen committed Jun 6, 2016
1 parent 5379be2 commit a84a49d
Showing 1 changed file with 0 additions and 19 deletions.
19 changes: 0 additions & 19 deletions drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,6 @@ struct panel_drv_data {

struct omap_video_timings videomode;

/* used for non-DT boot, to be removed */
int backlight_gpio;

struct gpio_desc *enable_gpio;
};

Expand Down Expand Up @@ -171,9 +168,6 @@ static int lb035q02_enable(struct omap_dss_device *dssdev)
if (ddata->enable_gpio)
gpiod_set_value_cansleep(ddata->enable_gpio, 1);

if (gpio_is_valid(ddata->backlight_gpio))
gpio_set_value_cansleep(ddata->backlight_gpio, 1);

dssdev->state = OMAP_DSS_DISPLAY_ACTIVE;

return 0;
Expand All @@ -190,9 +184,6 @@ static void lb035q02_disable(struct omap_dss_device *dssdev)
if (ddata->enable_gpio)
gpiod_set_value_cansleep(ddata->enable_gpio, 0);

if (gpio_is_valid(ddata->backlight_gpio))
gpio_set_value_cansleep(ddata->backlight_gpio, 0);

in->ops.dpi->disable(in);

dssdev->state = OMAP_DSS_DISPLAY_DISABLED;
Expand Down Expand Up @@ -256,8 +247,6 @@ static int lb035q02_probe_of(struct spi_device *spi)

ddata->enable_gpio = gpio;

ddata->backlight_gpio = -ENOENT;

in = omapdss_of_find_source_for_first_ep(node);
if (IS_ERR(in)) {
dev_err(&spi->dev, "failed to find video source\n");
Expand Down Expand Up @@ -290,13 +279,6 @@ static int lb035q02_panel_spi_probe(struct spi_device *spi)
if (r)
return r;

if (gpio_is_valid(ddata->backlight_gpio)) {
r = devm_gpio_request_one(&spi->dev, ddata->backlight_gpio,
GPIOF_OUT_INIT_LOW, "panel backlight");
if (r)
goto err_gpio;
}

ddata->videomode = lb035q02_timings;

dssdev = &ddata->dssdev;
Expand All @@ -316,7 +298,6 @@ static int lb035q02_panel_spi_probe(struct spi_device *spi)
return 0;

err_reg:
err_gpio:
omap_dss_put_device(ddata->in);
return r;
}
Expand Down

0 comments on commit a84a49d

Please sign in to comment.