Skip to content

Commit

Permalink
ipmi: Fix NULL pointer dereference in ssif_probe
Browse files Browse the repository at this point in the history
There is a potential execution path in which function ssif_info_find()
returns NULL, hence there is a NULL pointer dereference when accessing
pointer *addr_info*

Fix this by null checking *addr_info* before dereferencing it.

Addresses-Coverity-ID: 1473145 ("Explicit null dereferenced")
Fixes: e333054a91d1 ("ipmi: Fix I2C client removal in the SSIF driver")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
  • Loading branch information
Gustavo A. R. Silva authored and Corey Minyard committed Aug 31, 2018
1 parent 0745dde commit a8627cd
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/char/ipmi/ipmi_ssif.c
Original file line number Diff line number Diff line change
Expand Up @@ -1643,7 +1643,9 @@ static int ssif_probe(struct i2c_client *client, const struct i2c_device_id *id)

out:
if (rv) {
addr_info->client = NULL;
if (addr_info)
addr_info->client = NULL;

dev_err(&client->dev, "Unable to start IPMI SSIF: %d\n", rv);
kfree(ssif_info);
}
Expand Down

0 comments on commit a8627cd

Please sign in to comment.