Skip to content

Commit

Permalink
perf/x86/intel: Fix intel_get_event_constraints() for dynamic constra…
Browse files Browse the repository at this point in the history
…ints

With dynamic constraint, we need to restart from the static
constraints each time the intel_get_event_constraints() is called.

Signed-off-by: Stephane Eranian <eranian@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Maria Dimakopoulou <maria.n.dimakopoulou@gmail.com>
Cc: bp@alien8.de
Cc: jolsa@redhat.com
Cc: kan.liang@intel.com
Link: http://lkml.kernel.org/r/1416251225-17721-10-git-send-email-eranian@google.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
  • Loading branch information
Stephane Eranian authored and Ingo Molnar committed Apr 2, 2015
1 parent b63b4b4 commit a90738c
Showing 1 changed file with 10 additions and 5 deletions.
15 changes: 10 additions & 5 deletions arch/x86/kernel/cpu/perf_event_intel.c
Original file line number Diff line number Diff line change
Expand Up @@ -2063,20 +2063,25 @@ static struct event_constraint *
intel_get_event_constraints(struct cpu_hw_events *cpuc, int idx,
struct perf_event *event)
{
struct event_constraint *c = event->hw.constraint;
struct event_constraint *c1 = event->hw.constraint;
struct event_constraint *c2;

/*
* first time only
* - static constraint: no change across incremental scheduling calls
* - dynamic constraint: handled by intel_get_excl_constraints()
*/
if (!c)
c = __intel_get_event_constraints(cpuc, idx, event);
c2 = __intel_get_event_constraints(cpuc, idx, event);
if (c1 && (c1->flags & PERF_X86_EVENT_DYNAMIC)) {
bitmap_copy(c1->idxmsk, c2->idxmsk, X86_PMC_IDX_MAX);
c1->weight = c2->weight;
c2 = c1;
}

if (cpuc->excl_cntrs)
return intel_get_excl_constraints(cpuc, event, idx, c);
return intel_get_excl_constraints(cpuc, event, idx, c2);

return c;
return c2;
}

static void intel_put_excl_constraints(struct cpu_hw_events *cpuc,
Expand Down

0 comments on commit a90738c

Please sign in to comment.