Skip to content

Commit

Permalink
xen/cpuhotplug: Replace cpu_up/down() with device_online/offline()
Browse files Browse the repository at this point in the history
The core device API performs extra housekeeping bits that are missing
from directly calling cpu_up/down().

See commit a6717c0 ("powerpc/rtas: use device model APIs and
serialization during LPM") for an example description of what might go
wrong.

This also prepares to make cpu_up/down() a private interface of the cpu
subsystem.

Signed-off-by: Qais Yousef <qais.yousef@arm.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Juergen Gross <jgross@suse.com>
Link: https://lkml.kernel.org/r/20200323135110.30522-14-qais.yousef@arm.com
  • Loading branch information
Qais Yousef authored and Thomas Gleixner committed Mar 25, 2020
1 parent 02addae commit a926f81
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/xen/cpu_hotplug.c
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ static int setup_cpu_watcher(struct notifier_block *notifier,

for_each_possible_cpu(cpu) {
if (vcpu_online(cpu) == 0) {
(void)cpu_down(cpu);
device_offline(get_cpu_device(cpu));
set_cpu_present(cpu, false);
}
}
Expand Down

0 comments on commit a926f81

Please sign in to comment.