Skip to content

Commit

Permalink
sunrpc: Get xprt pointer once in xs_tcp_setup_socket
Browse files Browse the repository at this point in the history
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
  • Loading branch information
Pavel Emelyanov authored and J. Bruce Fields committed Oct 19, 2010
1 parent baaf4e4 commit a9f5f0f
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions net/sunrpc/xprtsock.c
Original file line number Diff line number Diff line change
Expand Up @@ -1851,12 +1851,12 @@ static int xs_tcp_finish_connecting(struct rpc_xprt *xprt, struct socket *sock)
*
* Invoked by a work queue tasklet.
*/
static void xs_tcp_setup_socket(struct rpc_xprt *xprt,
struct sock_xprt *transport,
static void xs_tcp_setup_socket(struct sock_xprt *transport,
struct socket *(*create_sock)(struct rpc_xprt *,
struct sock_xprt *))
{
struct socket *sock = transport->sock;
struct rpc_xprt *xprt = &transport->xprt;
int status = -EIO;

if (xprt->shutdown)
Expand Down Expand Up @@ -1958,9 +1958,8 @@ static void xs_tcp_connect_worker4(struct work_struct *work)
{
struct sock_xprt *transport =
container_of(work, struct sock_xprt, connect_worker.work);
struct rpc_xprt *xprt = &transport->xprt;

xs_tcp_setup_socket(xprt, transport, xs_create_tcp_sock4);
xs_tcp_setup_socket(transport, xs_create_tcp_sock4);
}

static struct socket *xs_create_tcp_sock6(struct rpc_xprt *xprt,
Expand Down Expand Up @@ -1997,9 +1996,8 @@ static void xs_tcp_connect_worker6(struct work_struct *work)
{
struct sock_xprt *transport =
container_of(work, struct sock_xprt, connect_worker.work);
struct rpc_xprt *xprt = &transport->xprt;

xs_tcp_setup_socket(xprt, transport, xs_create_tcp_sock6);
xs_tcp_setup_socket(transport, xs_create_tcp_sock6);
}

/**
Expand Down

0 comments on commit a9f5f0f

Please sign in to comment.