Skip to content

Commit

Permalink
kgdb: remove custom hex_to_bin()implementation
Browse files Browse the repository at this point in the history
Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
  • Loading branch information
Andy Shevchenko authored and Jason Wessel committed Aug 5, 2010
1 parent 9fe6206 commit a9fa20a
Showing 1 changed file with 5 additions and 16 deletions.
21 changes: 5 additions & 16 deletions kernel/debug/gdbstub.c
Original file line number Diff line number Diff line change
Expand Up @@ -52,17 +52,6 @@ static unsigned long gdb_regs[(NUMREGBYTES +
* GDB remote protocol parser:
*/

static int hex(char ch)
{
if ((ch >= 'a') && (ch <= 'f'))
return ch - 'a' + 10;
if ((ch >= '0') && (ch <= '9'))
return ch - '0';
if ((ch >= 'A') && (ch <= 'F'))
return ch - 'A' + 10;
return -1;
}

#ifdef CONFIG_KGDB_KDB
static int gdbstub_read_wait(void)
{
Expand Down Expand Up @@ -123,8 +112,8 @@ static void get_packet(char *buffer)
buffer[count] = 0;

if (ch == '#') {
xmitcsum = hex(gdbstub_read_wait()) << 4;
xmitcsum += hex(gdbstub_read_wait());
xmitcsum = hex_to_bin(gdbstub_read_wait()) << 4;
xmitcsum += hex_to_bin(gdbstub_read_wait());

if (checksum != xmitcsum)
/* failed checksum */
Expand Down Expand Up @@ -280,8 +269,8 @@ int kgdb_hex2mem(char *buf, char *mem, int count)
tmp_hex = tmp_raw - 1;
while (tmp_hex >= buf) {
tmp_raw--;
*tmp_raw = hex(*tmp_hex--);
*tmp_raw |= hex(*tmp_hex--) << 4;
*tmp_raw = hex_to_bin(*tmp_hex--);
*tmp_raw |= hex_to_bin(*tmp_hex--) << 4;
}

return probe_kernel_write(mem, tmp_raw, count);
Expand All @@ -304,7 +293,7 @@ int kgdb_hex2long(char **ptr, unsigned long *long_val)
(*ptr)++;
}
while (**ptr) {
hex_val = hex(**ptr);
hex_val = hex_to_bin(**ptr);
if (hex_val < 0)
break;

Expand Down

0 comments on commit a9fa20a

Please sign in to comment.