Skip to content

Commit

Permalink
Merge branch '8390-cleanups'
Browse files Browse the repository at this point in the history
Finn Thain says:

====================
Fixes, cleanup and modernization for 8390 ethernet drivers

Changes since v4 of combined patch series:
- Removed redundant and non-portable MACH_IS_MAC tests.
- Added acked-by tags from Geert Uytterhoeven.
- Omitted patches unrelated to 8390 drivers.
====================

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David S. Miller committed Feb 21, 2018
2 parents 4be83e5 + 4a1b27c commit aa00d40
Show file tree
Hide file tree
Showing 14 changed files with 85 additions and 141 deletions.
3 changes: 0 additions & 3 deletions drivers/net/Space.c
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,6 @@ static struct devprobe2 m68k_probes[] __initdata = {
#ifdef CONFIG_MVME147_NET /* MVME147 internal Ethernet */
{mvme147lance_probe, 0},
#endif
#ifdef CONFIG_MAC8390 /* NuBus NS8390-based cards */
{mac8390_probe, 0},
#endif
#ifdef CONFIG_MAC89x0
{mac89x0_probe, 0},
#endif
Expand Down
6 changes: 3 additions & 3 deletions drivers/net/ethernet/8390/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@ obj-$(CONFIG_MAC8390) += mac8390.o
obj-$(CONFIG_APNE) += apne.o 8390.o
obj-$(CONFIG_ARM_ETHERH) += etherh.o
obj-$(CONFIG_AX88796) += ax88796.o
obj-$(CONFIG_HYDRA) += hydra.o 8390.o
obj-$(CONFIG_MCF8390) += mcf8390.o 8390.o
obj-$(CONFIG_HYDRA) += hydra.o
obj-$(CONFIG_MCF8390) += mcf8390.o
obj-$(CONFIG_NE2000) += ne.o 8390p.o
obj-$(CONFIG_NE2K_PCI) += ne2k-pci.o 8390.o
obj-$(CONFIG_PCMCIA_AXNET) += axnet_cs.o 8390.o
obj-$(CONFIG_PCMCIA_PCNET) += pcnet_cs.o 8390.o
obj-$(CONFIG_STNIC) += stnic.o 8390.o
obj-$(CONFIG_ULTRA) += smc-ultra.o 8390.o
obj-$(CONFIG_WD80x3) += wd.o 8390.o
obj-$(CONFIG_ZORRO8390) += zorro8390.o 8390.o
obj-$(CONFIG_ZORRO8390) += zorro8390.o
3 changes: 0 additions & 3 deletions drivers/net/ethernet/8390/ax88796.c
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,6 @@ static unsigned char version[] = "ax88796.c: Copyright 2005,2007 Simtec Electron

#define AX_GPOC_PPDSET BIT(6)

static u32 ax_msg_enable;

/* device private data */

struct ax_device {
Expand Down Expand Up @@ -747,7 +745,6 @@ static int ax_init_dev(struct net_device *dev)
ei_local->block_output = &ax_block_output;
ei_local->get_8390_hdr = &ax_get_8390_hdr;
ei_local->priv = 0;
ei_local->msg_enable = ax_msg_enable;

dev->netdev_ops = &ax_netdev_ops;
dev->ethtool_ops = &ax_ethtool_ops;
Expand Down
2 changes: 0 additions & 2 deletions drivers/net/ethernet/8390/axnet_cs.c
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ static void AX88190_init(struct net_device *dev, int startp);
static int ax_open(struct net_device *dev);
static int ax_close(struct net_device *dev);
static irqreturn_t ax_interrupt(int irq, void *dev_id);
static u32 axnet_msg_enable;

/*====================================================================*/

Expand Down Expand Up @@ -151,7 +150,6 @@ static int axnet_probe(struct pcmcia_device *link)
return -ENOMEM;

ei_local = netdev_priv(dev);
ei_local->msg_enable = axnet_msg_enable;
spin_lock_init(&ei_local->page_lock);

info = PRIV(dev);
Expand Down
17 changes: 0 additions & 17 deletions drivers/net/ethernet/8390/etherh.c
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,6 @@ static char version[] =

#include "lib8390.c"

static u32 etherh_msg_enable;

struct etherh_priv {
void __iomem *ioc_fast;
void __iomem *memc;
Expand Down Expand Up @@ -501,18 +499,6 @@ etherh_close(struct net_device *dev)
return 0;
}

/*
* Initialisation
*/

static void __init etherh_banner(void)
{
static int version_printed;

if ((etherh_msg_enable & NETIF_MSG_DRV) && (version_printed++ == 0))
pr_info("%s", version);
}

/*
* Read the ethernet address string from the on board rom.
* This is an ascii string...
Expand Down Expand Up @@ -671,8 +657,6 @@ etherh_probe(struct expansion_card *ec, const struct ecard_id *id)
struct etherh_priv *eh;
int ret;

etherh_banner();

ret = ecard_request_resources(ec);
if (ret)
goto out;
Expand Down Expand Up @@ -757,7 +741,6 @@ etherh_probe(struct expansion_card *ec, const struct ecard_id *id)
ei_local->block_output = etherh_block_output;
ei_local->get_8390_hdr = etherh_get_header;
ei_local->interface_num = 0;
ei_local->msg_enable = etherh_msg_enable;

etherh_reset(dev);
__NS8390_init(dev, 0);
Expand Down
4 changes: 0 additions & 4 deletions drivers/net/ethernet/8390/hydra.c
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ static void hydra_block_input(struct net_device *dev, int count,
static void hydra_block_output(struct net_device *dev, int count,
const unsigned char *buf, int start_page);
static void hydra_remove_one(struct zorro_dev *z);
static u32 hydra_msg_enable;

static struct zorro_device_id hydra_zorro_tbl[] = {
{ ZORRO_PROD_HYDRA_SYSTEMS_AMIGANET },
Expand Down Expand Up @@ -119,7 +118,6 @@ static int hydra_init(struct zorro_dev *z)
int start_page, stop_page;
int j;
int err;
struct ei_device *ei_local;

static u32 hydra_offsets[16] = {
0x00, 0x02, 0x04, 0x06, 0x08, 0x0a, 0x0c, 0x0e,
Expand All @@ -138,8 +136,6 @@ static int hydra_init(struct zorro_dev *z)
start_page = NESM_START_PG;
stop_page = NESM_STOP_PG;

ei_local = netdev_priv(dev);
ei_local->msg_enable = hydra_msg_enable;
dev->base_addr = ioaddr;
dev->irq = IRQ_AMIGA_PORTS;

Expand Down
2 changes: 2 additions & 0 deletions drivers/net/ethernet/8390/lib8390.c
Original file line number Diff line number Diff line change
Expand Up @@ -975,6 +975,8 @@ static void ethdev_setup(struct net_device *dev)
ether_setup(dev);

spin_lock_init(&ei_local->page_lock);

ei_local->msg_enable = msg_enable;
}

/**
Expand Down
Loading

0 comments on commit aa00d40

Please sign in to comment.