Skip to content

Commit

Permalink
fsi: scom: Fix NULL dereference
Browse files Browse the repository at this point in the history
The chardev conversion forgot to copy the fsi_dev,
silly mistake, compounded by a testing mistake on
my side, this specific driver wasn't being tested
properly.

Fixes: d8f4587 "fsi: scom: Convert to use the new chardev"
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
  • Loading branch information
Benjamin Herrenschmidt committed Aug 6, 2018
1 parent 9840fcd commit aa1221b
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/fsi/fsi-scom.c
Original file line number Diff line number Diff line change
Expand Up @@ -598,6 +598,7 @@ static int scom_probe(struct device *dev)
kfree(scom);
return -ENODEV;
}
scom->fsi_dev = fsi_dev;

/* Create chardev for userspace access */
scom->dev.type = &fsi_cdev_type;
Expand Down

0 comments on commit aa1221b

Please sign in to comment.