Skip to content

Commit

Permalink
drm/i915/gvt: cleanup debugfs scan_nonprivbb
Browse files Browse the repository at this point in the history
Remove extra chatty message for debugfs scan_nonprivbb which is used
to enable scan for non privileged batch on specific engine. Just write
target i915 engine mask instead.

Cc: Ding Zhuocheng <zhuocheng.ding@intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Zhenyu Wang <zhenyuw@linux.intel.com>
Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20200304032307.2983-1-zhenyuw@linux.intel.com
  • Loading branch information
Chris Wilson authored and Zhenyu Wang committed Mar 6, 2020
1 parent 135dde8 commit aa444fc
Showing 1 changed file with 1 addition and 35 deletions.
36 changes: 1 addition & 35 deletions drivers/gpu/drm/i915/gvt/debugfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ static int
vgpu_scan_nonprivbb_get(void *data, u64 *val)
{
struct intel_vgpu *vgpu = (struct intel_vgpu *)data;

*val = vgpu->scan_nonprivbb;
return 0;
}
Expand All @@ -142,42 +143,7 @@ static int
vgpu_scan_nonprivbb_set(void *data, u64 val)
{
struct intel_vgpu *vgpu = (struct intel_vgpu *)data;
struct drm_i915_private *dev_priv = vgpu->gvt->dev_priv;
enum intel_engine_id id;
char buf[128], *s;
int len;

val &= (1 << I915_NUM_ENGINES) - 1;

if (vgpu->scan_nonprivbb == val)
return 0;

if (!val)
goto done;

len = sprintf(buf,
"gvt: vgpu %d turns on non-privileged batch buffers scanning on Engines:",
vgpu->id);

s = buf + len;

for (id = 0; id < I915_NUM_ENGINES; id++) {
struct intel_engine_cs *engine;

engine = dev_priv->engine[id];
if (engine && (val & (1 << id))) {
len = snprintf(s, 4, "%d, ", engine->id);
s += len;
} else
val &= ~(1 << id);
}

if (val)
sprintf(s, "low performance expected.");

pr_warn("%s\n", buf);

done:
vgpu->scan_nonprivbb = val;
return 0;
}
Expand Down

0 comments on commit aa444fc

Please sign in to comment.