Skip to content

Commit

Permalink
ALSA: aoa: Delete an unnecessary check before the function call "snd_…
Browse files Browse the repository at this point in the history
…pcm_suspend_all"

The snd_pcm_suspend_all() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Markus Elfring authored and Takashi Iwai committed Jan 4, 2015
1 parent b172e0a commit aa57b93
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions sound/aoa/soundbus/i2sbus/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -381,10 +381,8 @@ static int i2sbus_suspend(struct macio_dev* dev, pm_message_t state)

list_for_each_entry(i2sdev, &control->list, item) {
/* Notify Alsa */
if (i2sdev->sound.pcm) {
/* Suspend PCM streams */
snd_pcm_suspend_all(i2sdev->sound.pcm);
}
/* Suspend PCM streams */
snd_pcm_suspend_all(i2sdev->sound.pcm);

/* Notify codecs */
list_for_each_entry(cii, &i2sdev->sound.codec_list, list) {
Expand Down

0 comments on commit aa57b93

Please sign in to comment.