Skip to content

Commit

Permalink
perf machine: Fix path unpopulated in machine__create_modules()
Browse files Browse the repository at this point in the history
In machine__create_modules() the 'path' char array was used in a call to
symbol__restricted_filename() without always being populated.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1379845338-29637-2-git-send-email-adrian.hunter@intel.com
[ Split patch removing unrelated conversion of sprintf to snprintf to perf/core ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Adrian Hunter authored and Arnaldo Carvalho de Melo committed Sep 25, 2013
1 parent 6d19912 commit aa7fe3b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/perf/util/machine.c
Original file line number Diff line number Diff line change
Expand Up @@ -792,7 +792,7 @@ static int machine__create_modules(struct machine *machine)
modules = path;
}

if (symbol__restricted_filename(path, "/proc/modules"))
if (symbol__restricted_filename(modules, "/proc/modules"))
return -1;

file = fopen(modules, "r");
Expand Down

0 comments on commit aa7fe3b

Please sign in to comment.